This project is archived and is in readonly mode.
has_many :conditions and named_scope should alter creates from within it
Reported by ronin-23439 (at lighthouseapp) | June 15th, 2008 @ 03:05 AM
This has been a problem in rails for a very long time and I am shocked that it has not been fixed yet. What I say here about has_many essentially applies just the same to named_scope.
Assume I have a class Post. Post has a boolean field 'published', indicating whether the post has been published or not. I also have another class, Blog. If I want the blog to have many posts, which is just any posts in general, and to also have only posts which have been published:
class Blog < ActiveRecord::Base
has_many :posts
has_many :published_posts, :conditions => {:published => true}, :class_name => 'Post'
end
Blog.published_posts.find(:all) works just as expected. But what if I want to do the following in order to have the blog post it immediately:
Blog.published_posts.create(:title => 'The Blog Post')
This doesn't automatically alter the condition of to true. This seems odd, and inconsistent since the only way to access this record is from Blog.posts, rather than Blog.published_posts, where I created it from.
The obvious problem that arises is that if the conditions are not exactly specific about which alterations need to be done such as 'date < 2008' the create cannot work with this. I suggest that to patch this, if a hash is being used for conditions it can be used on either a create or a find since the values are specific. Otherwise :conditions only applies to the find and an alternate :create_conditions can be used for creates.
Comments and changes to this ticket
-
Jeremy Kemper June 15th, 2008 @ 04:29 AM
- Milestone cleared.
- State changed from “new” to “open”
That'd be a nice addition for Hash :conditions. Please do investigate! Have create look at :conditions in the :find scope and check for a Hash.
-
Jeremy Kemper June 15th, 2008 @ 04:32 AM
Regarding "this has been a problem in rails for a very long time and I am shocked that it has not been fixed yet"
Typically :conditions could not be interpreted purely as an attributes hash. Only relatively recently were :conditions hashes introduced. This wasn't a problem even then, just a missing feature. What is shocking about this?
-
Daniel Guettler June 18th, 2008 @ 02:55 AM
This has already been added in commit c23c9bd1 in response to ticket http://dev.rubyonrails.org/ticke...
Or am I missing something?
-
ronin-23439 (at lighthouseapp) June 18th, 2008 @ 03:54 AM
Yes, this was my ticket as well I put this ticket in to include named_scope and because I wasn't sure if that original Trac site was being used anymore.
-
Daniel Guettler June 18th, 2008 @ 06:44 AM
Here a possible patch which adds build, create and create! methods to the named_scope similar to associations.
-
Daniel Guettler June 18th, 2008 @ 02:43 PM
- no changes were found...
-
Repository July 9th, 2008 @ 02:22 PM
- State changed from “open” to “resolved”
- Tag set to “activerecord, associations, create, enhancement, has_many, patch, tested”
(from [84af99e78dbf65b7faa92313acf8457cb0c2b510]) Ensure NamedScope#build/create/create!/new works as expected when named scope has hash conditions. [Daniel Guettler, Pratik Naik] [#419 state:resolved]
Signed-off-by: Pratik Naik
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Daniel Guettler
Jeremy Kemper