This project is archived and is in readonly mode.
Patch for incorrect template choice in ActionController::Responder
The current head version of the bundled
ActionController::Responder has a bug
that causes it to render new even if the method is put when the
method is overriden.
This was caused by recent (well, Rails 3.0.0.beta3) changes that
introduced
request.request_method and it's counterparts alongside
request.method, the former
being equivalent to the old version of the latter. Unfortunately,
in this change
the responder didn't get updated to use the correct method
(request_method_symbol
versus the incorrect method_symbol).
The attached patch fixes this and includes tests that reproduce
the bug. It applies
cleanly on master as of May 9th, 2010.
-
rails3-responder-fix.patch
2.99 KB
-
Dan Pickett- Tag changed from action_controller, bug, patch, rails3, responder to action_controller, bug, bugmash, patch, rails3, responder
-
Diego Algortaverified
Submitting a rebased patch for current master with no changes.
-
Michal Kuklis+1 verified on master
-
Enrico Bianco+1
Applies cleanly against master, verified that the test fails without the provided code that fixes the issue (and that tests pass when it is in place).
-
Antti TarvainenI didn't notice this ticket, and created a patch too, attached. I am happy with Diego's solution, but here's an alternative for reference, with a slightly different way of testing.
-
Darcy LaycockLooks like http://github.com/rails/rails/commit/59d1c418be47694a5b79d860bced6f... fixes this independently so it can be ignored now.
-
Rohit Arondekar- State changed from new to resolved