#5663 Route generation error with :defaults and :via options - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5663 open

Route generation error with :defaults and :via options

Reported by BicycleRepairMan | September 19th, 2010 @ 04:14 PM | in 3.0.6

There seems to be a problem when we use the :defaults and :via options simultaneously to match a route. The attached unit test should not fail! Also if the routes.rb file looks like

RouteBug::Application.routes.draw do
  match '/error' => "bug#index", :defaults => {:format => "jpg"}, :via => :get
end

then

RAILS_ENV=env rails runner 'RouteBug::Application.routes.generate :controller => :bug'

raises an error in test and production mode, but not in development mode.

I tested this with ruby 1.9.2p0 (2010-08-18 revision 29036) [i686-linux] compiled from source and the ubuntu lucid ruby 1.8.7 (2010-01-10 patchlevel 249) [i486-linux].

route_test.rb 1.3 KB

Comments and changes to this ticket

Andrew White September 19th, 2010 @ 10:39 PM
- Milestone cleared.
- State changed from “new” to “open”
- Assigned user set to “josh”
- Importance changed from “” to “Low”
This is another subtle Rack::Mount bug to do with key analysis. The reason it doesn't work in test or production is that the built-in info route isn't included and this is enough to trigger the bug. If you add some additional routes inside the test it passes.

It looks as though :format is getting added to the generation_keys array because the :request_method condition is including it in required_defaults. Once you have other routes the :format key drops out of generation_keys due to the increased frequency of the :controller and :action keys.
Jeremy Kemper October 15th, 2010 @ 11:02 PM
- Milestone set to “3.0.2”
[bulk edit]
Ryan Bigg October 16th, 2010 @ 02:22 AM
- Tag changed from “sheepskin boots, routes” to “routes”
Automatic cleanup of spam.
Ryan Bigg October 19th, 2010 @ 08:35 AM
- Tag cleared.
Automatic cleanup of spam.
Santiago Pastorino November 15th, 2010 @ 09:15 PM
- Milestone cleared.
[bulk edit]
Santiago Pastorino February 12th, 2011 @ 09:58 PM
- Milestone set to “3.0.5”
[bulk edit]
Santiago Pastorino February 27th, 2011 @ 03:15 AM
- Milestone changed from “3.0.5” to “3.0.6”
[bulk edit]