Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Fjan November 20th, 2010 @ 08:43 PM

  Here is a monkey patch that you can drop into your rails initializers if you are in a hurry to fix this because you have a client with a mobile phone who really needs access. I'm fully aware this is not a proper solution but it might help someone.

  
  module ActionDispatch
    module Http
      module MimeNegotiation
  
        # Patched to always accept at least HTML
        def accepts
          @env["action_dispatch.request.accepts"] ||= begin
            header = @env['HTTP_ACCEPT'].to_s.strip
  
            if header.empty?
              [content_mime_type]
            else
              Mime::Type.parse(header) << Mime::HTML
            end
          end
        end
  
      end
    end
  end
  

• 

  José Valim November 20th, 2010 @ 11:55 PM

  • Assigned user set to “José Valim”
  • Importance changed from “” to “Low”
• 

  Neeraj Singh November 22nd, 2010 @ 10:42 PM

  • State changed from “new” to “open”

  This patch takes care of all the three cases you outlined. https://github.com/rails/rails/compare/c937ddb...21fd93c

  HTTP_ACCEPT: text/
  HTTP_ACCEPT: /, auth/sicily
  HTTP_ACCEPT: /*, application/youtube-client

  More work is needed. But that's a start. Please check if that patch fixes your problem.

• You flagged this item as spam.
  

  Fjan November 23rd, 2010 @ 10:34 AM

  Thank you for that, that does indeed seem to cover all the cases.

  I've never seen a browser ask for image/ or application/ though, so we could make it easier on ourselves and assume any client that asks for a page with an HTML view can accept an HTML view. Simplifies the code and might be a bit more robust in serving clients that have an accept header that is plain/wrong. ("Do we want to be right or do we want to be pragmatic?"). Since you've gone through the trouble of creating this patch already I say being right is fine :-)

• 

  Repository November 23rd, 2010 @ 10:33 PM

  • State changed from “open” to “resolved”

  (from [d33dcba72d19beffc4a359f2fb89659f24122e9a]) Do not send id for quoting twice if the primary key is string.

  [#6022 state:resolved] https://github.com/rails/rails/commit/d33dcba72d19beffc4a359f2fb896...

• 

  Neeraj Singh November 24th, 2010 @ 01:28 AM

  • State changed from “resolved” to “open”

  I guess I put in wrong ticket # in the previous fix. Opening this ticket.

• 

  José Valim November 25th, 2010 @ 09:46 AM

  • Assigned user changed from “José Valim” to “Neeraj Singh”

  I believe this can be closed, right Neeraj?

• 

  Neeraj Singh November 25th, 2010 @ 05:52 PM

  • State changed from “open” to “resolved”
• 

  Neeraj Singh November 26th, 2010 @ 09:49 PM

  Just listing the list of changes done as part of second set of changes.

  https://github.com/rails/rails/compare/c6030e8...fa2a5ae

• 

  Repository December 9th, 2010 @ 05:53 PM

  (from [d67464a160bf2a5ef899a14cff93756aad374a6a]) Do not send id for quoting twice if the primary key is string.

  [#6022 state:resolved] https://github.com/rails/rails/commit/d67464a160bf2a5ef899a14cff937...

• You flagged this item as spam.
  

  Kenn Ejima January 8th, 2011 @ 06:14 AM

  I have another case for the same error that still fails with this commit

  • HTTP_ACCEPT: */*;q=0.01

  There's a semicolon in the string, the user agent was Mozilla/4.0 (PSP (PlayStation Portable); 2.00).

• You flagged this item as spam.
  

  Kenn Ejima January 8th, 2011 @ 08:29 AM

  This one should fall back to html (or plain text), too. It was sent from Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1).

  • HTTP_ACCEPT: text/*
• 

  Neeraj Singh January 9th, 2011 @ 12:07 AM

  can you describe what error msg you are getting and what's the setup?

• You flagged this item as spam.
  

  Kenn Ejima January 9th, 2011 @ 02:17 AM

  On Rails 3.0.3 + Ruby 1.9.2, the same "template missing" error as Fjan described.

  Now my patch has the following regex in ActionDispatch::Http::MimeNegotiation:

  BROWSER_LIKE_ACCEPTS = /,\s*\*\/\*|\*\/\*\s*,|\*\/\*;|text\/\*/

  however I'm not sure if it's a good idea to keep adding exceptions in this manner - probably we should just at least try to find html template rather than throwing an exception? I don't know if there's a good reason when "template missing" is useful on production.

• You flagged this item as spam.
  

  Fjan January 9th, 2011 @ 09:13 AM

  Yes, I actually ended up using the monkey patch above that just return the HTML template if no other is available. There are just to many odd headers out there.

• You flagged this item as spam.
  

  Joel Chippindale February 7th, 2011 @ 12:59 PM

  Keen Ejima,

  The bug you mentioned with

  HTTP_ACCEPT: */*;q=0.01
  

  Is covered by #5833 which includes a patch to fix.

  J.

• You flagged this item as spam.
  

  William Denniss April 2nd, 2011 @ 03:11 AM

  I think the monkey patch above isn't a bad idea actually – as a fallback. Maybe an option like this could actually be considered for inclusion? Otherwise, aren't we forever having to patch rails for every obscure accepts header found in the wild?

  Does returning status code 500 even make sense for these "bad" (in ruby's eyes) requests?

  I'm pretty happy with the idea "clients that know what they are doing can request alternative formats – everyone else gets html".