This project is archived and is in readonly mode.
AUTOLINK_RE ruby 1.9 compatibility fix
Reported by Stefan Kaes | August 8th, 2008 @ 10:23 AM | in 2.x
ruby 1.9 complains about some regexp being too complex:
activesupport/lib/active_support/dependencies.rb:510: warning: nested repeat operator + and ? was replaced with '*'
not very helpful, eh?
after tracing the requires I simplified
(?:/(?:(?:[~\w\+@%=\(\)-]|(?:[,.;:'][^\s$]))+)?)* # path
to
(?:/(?:[~\w\+@%=\(\)-]|(?:[,.;:'][^\s$]))*)* # path
this stops the warning, and should be equivalent (I think so and there no test failures).
Comments and changes to this ticket
-
Stefan Kaes August 8th, 2008 @ 10:41 AM
- no changes were found...
-
josh August 9th, 2008 @ 06:40 AM
- Assigned user set to “josh”
-
-
Stefan Kaes August 9th, 2008 @ 04:40 PM
so? the first regexp can be transformed into the second, is simpler, semantically equivalent and stops the warning. why not apply the fix?
-
-
Repository August 9th, 2008 @ 04:49 PM
- State changed from “new” to “resolved”
(from [b2630502a0525e5965d4eff283e3d2613cd1ca19]) Fixed autolink regexp compatibility for ruby 1.9 [#783 state:resolved] Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
josh
Repository
Stefan Kaes
Attachments
Tags
Referenced by
-
783
AUTOLINK_RE ruby 1.9 compatibility fix
(from [b2630502a0525e5965d4eff283e3d2613cd1ca19]) Fixed a...