Activity (RSS)

Um, the patches are gone now?

Both patches are the same, accidentally double posted (because I didn't see it appear the first time). Trying to delete visually makes it disappear, but it is...

+1

When working with custom caching, I switched from memory_store to file_store and started having a number of errors that I at first assumed were my own. Upon f...

(from [e6a3ce3392812f707b78d64ffb04ee52f4517d20]) Make sure member names aren't mistakenly set to nil when providing :path_names

[#19 state:resolved]

Signed-...

(from [b6aa0e13b4e590b82550a6464924f431e57229df]) Fix include? on has_many collections with finder_sql to fall back to Array include? rather than try to use SQ...

Yeah, this looks good to go if you could switch it to use quote_column_name instead of the table name, and upload the two patches into a single patch file. Fo...

Could you add the tests to the .patch you've attached please? Two style issues

if (reflection.klass rescue nil) and reflection.klass.respond_to?(:attr_read...

Thank you, fixed in doc-rails:

http://github.com/lifo/doc-rails...

(from [ae51013c3f7b8a8579fcb99d889ed80e9dd75797]) Provide data for the key column otherwise adding a unique index will fail. [#30 state:closed]

http://github....

Adding patch. [I thought I just did that.]

I really hate typing unless @foo.errors.blank? when I really mean if @user.has_errors? and thought this might make a good patch on Rails. Calling #invalid? act...

This patch adds the block syntax to the ActiveRecord class methods create and update.

For example it allows this:

@person = Person.create(params[:person]) do...

OK:

http://github.com/chrislloyd/rai...

I was just using the example given in the CHANGELOG, but you were right about it being incorrect. I've modified it so...

Looks like the example is not valid:

actionpack/lib/action_controller/routing/builder.rb:104:in `assign_route_options': Regexp anchor characters are not allow...

Currently the rake:db_create and rake:db_drop tasks will connect to the PostgreSQL server with a nil database, which causes PostgreSQL to look for a database w...

Yeah this one's a no brainer. +1

I ran rake rdoc in the root level of my locally cloned fork of the rails repository, did some work, and then ran git status. I'd rather not be asked by git to ...

I think I found the correct author info. Next time try using git format patch so it includes your name and email.

(from [bf1b1e0925085811f0b58bb4093e678438ea0236]) Rails Edge info returns the latest git commit hash [#36 state:resolved]

Signed-off-by: Joshua Peek

http://...

The hash still seems rather useless but its better than unknown.

`script/about` returns unknow as Edge Rails Version.

I've updated the `module Info` to use git as the default SCM.

Doh, didn't even look for it under that name. Ok, ignore this ticket.

Take a look at Hash#slice in ActiveSupport (slice.rb) :) I think someone opened a similar ticket with patch in Trac before. Personally, I prefer #only but well...

I've added Hash#only (opposite of Hash#except) for picking specific attributes out of a hash:

{:a => 1, :b => 2, :c => 3}.only(:a, :c)

http://github.com/bra...

Exactly. If you look at the old eager loading code it basically did that.

Ahhh... I think I see where you are going with this. Casting _parent_record_id to a string (and everything it's compared to) would not lose any fidelity incom...

Not everywhere, just for the bits in association preload where it's trying to match up records to their owners. I'll give it a go and see if it works

Frederick,

I love you man, but I just don't think that would work. It would require unprecedented Ruby fu to always pull off the "123" == 123 when comparing ...

Could we not go the other way and assume all keys are strings ?

Due to the class loading feature in Rails, a model class with counter_cache could be loaded before its associated class, which may cause attr_readonly for "[mo...

patch with schema specific schema.rb files.

The change to the adapter is because of http://www.postgresql.org/docs/8... and if my reading of that is correct, probably should have been like that all along...

There's a change to the postgresql adapter that I don't quite follow. Is it meant to be in this change?

The only other thought I had was perhaps we could put...

I've fixed this in a fork of the 2-0-branch on github. The fix is present in this tree (and is the only change):

http://github.com/rsutphin/rails...

I'm not...