Rails Ruby on Rails → 2.1.1

Comments and changes to this ticket

• 

  josh May 8th, 2008 @ 06:20 AM

  • Assigned user set to “josh”
  • State changed from “new” to “open”

  Verified. Post a fix w/ tests and I'll get it in for ya.

  $ script/generate controller admin::people
        create  app/controllers/admin
        create  app/helpers/admin
        create  app/views/admin/people
        create  test/functional/admin
        create  app/controllers/admin/people_controller.rb
        create  test/functional/admin/people_controller_test.rb
        create  app/helpers/admin/people_helper.rb
  $ script/generate controller admin::projects
    The name 'admin' is reserved by Ruby on Rails.
    Please choose an alternative and run this generator again.
  
    Suggestions:  
  

• You flagged this item as spam.
  

  Amol Hatwar (rubygem) May 8th, 2008 @ 08:02 PM

  Thanks for verifying the bug quickly :o). I couldn't find much time to dig deep into it today. The situation may stay the same till after the weekend.

  I think, this bit of code from line 169 onwards of the file: railties/lib/rails_generator/commands.rb is acting funny.

  -- BEGINS --

  # Extract the last Module in the nesting.
  last = nesting.inject(Object) { |last, nest|
                break unless last.const_defined?(nest)
                last.const_get(nest)
              }
  

  -- ENDS --

  It doesn't really return the last module in most cases...

• You flagged this item as spam.
  

  Amol Hatwar (rubygem) May 12th, 2008 @ 02:30 AM

  OK, I seem to have gotten rid of this bug to some extent. What I couldn't fix (yet), is having a controllers nested within modules with the same names which is allowed in Rails 2.0.2

  For getting that behavior in, I guess we'll have to store entire module hierarchies and run checks on them... or, perhaps drop collision checking entirely :(

  git binary patch file attached

  • 0001-Fixed-collissions-for-nested-controller-modules.patch 15.4 KB
• 

  josh May 13th, 2008 @ 10:04 PM

  • Milestone set to “2.1.1”
  • State changed from “open” to “resolved”

  http://github.com/rails/rails/co...

• You flagged this item as spam.
  

  rwl June 1st, 2008 @ 02:07 AM

  hey guys, been having trouble with this, too. switching braches to v2.1.0_RC1 got it working, but not exaclty a longterm solution.

  what did you guys end up doing? or do i just need to modify the nested name?

• You flagged this item as spam.
  

  rwl June 1st, 2008 @ 11:12 AM

  there was a patch to the main branch today that redefined the error. i will build a test app to try it out.

• You flagged this item as spam.
  

  Amol Hatwar (rubygem) June 2nd, 2008 @ 01:20 AM

  I think I was able to fix it. The patch is already live on edge...

• You flagged this item as spam.
  

  Claudio Poli July 22nd, 2008 @ 12:53 PM

  • Tag set to “generators, railties”

  tried today, same error (edge)

  http://pastie.org/238523

• You flagged this item as spam.
  

  Claudio Poli July 22nd, 2008 @ 12:56 PM

  another reference

  http://groups.google.com/group/r...

• You flagged this item as spam.
  

  Claudio Poli July 22nd, 2008 @ 01:44 PM

  hrm.. problem got solved by commenting helper :all in ApplicationController (rails default).

• You flagged this item as spam.
  

  Michael Trim July 23rd, 2008 @ 11:18 PM

  • Tag changed from “generators, railties” to “bug, generators, railties”

  Shouldn't this ticket be reopened, since the patch has been reverted? (In any case the patch doesn't do the right thing as far as I can tell.)

  Like kain, I find it works if helper :all in ApplicationController is commented. I'm not sure why ApplicationController needs to be loaded to run the generator, but obviously when the helpers get loaded any Modules that they are in are present so the generator complains.

• You flagged this item as spam.
  

  ronin-16982 (at lighthouseapp) September 16th, 2008 @ 09:00 PM

  • Tag changed from “bug, generators, railties” to “bug, generators, railties”

  I also think this ticket should be reopened since the patch was reverted (see #545) and people still run into the problem (see #1059).

• You flagged this item as spam.
  

  ronin-16982 (at lighthouseapp) September 16th, 2008 @ 09:16 PM

  Ok, no need to reopen since it seems to be fixed in egde and 2.1.1. Both testcases (from this ticket and from #545) work for me.

  Sorry for noise...