This project is archived and is in readonly mode.
to_sentence breaks api
Reported by Niels Meersschaert | February 2nd, 2009 @ 08:38 PM
The new words_connector args are great for moving forward, but if you use the Rails 2.2 era to_sentence(:connector => "or") param hash you get errors. Ideally, this should be deprecated, but the old :connector should be mapped to :words_connector in the interim.
Comments and changes to this ticket
-
DHH February 6th, 2009 @ 02:06 PM
- Milestone cleared.
-
Guillermo Álvarez February 7th, 2009 @ 06:19 PM
- Tag changed from 2.3, active_support to 2.3, active_support, i18n, patch, tested
Posible solution with tests
-
Repository February 22nd, 2009 @ 03:13 PM
- State changed from new to committed
(from [ff1afbd65098643a06eef928f92fecf6e9d548b2]) Deprecated warnings for :skip_last_command and :connector of to_sentence [#1847 state:committed]
Signed-off-by: David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 2010 Array#to_sentence raises with missing translations This will need to be merged with Ticket #1847 if accepted.
- 1847 to_sentence breaks api (from [ff1afbd65098643a06eef928f92fecf6e9d548b2]) Depreca...
- 2010 Array#to_sentence raises with missing translations Includes changes from commit ff1afb, #1847.