This project is archived and is in readonly mode.

#1952 ✓resolved
Joe F.

Bug using response.headers["expires"]

Reported by Joe F. | February 12th, 2009 @ 04:10 PM

Just upgraded our project to edge Rails and we saw an exception using response.headers["expires"]. We looked at the code and found the problem. I have attached the patch. Is this actually a bug? Could we get it in before 2.3 is final?

Thanks! Joe Fiorini

Comments and changes to this ticket

  • josh

    josh February 12th, 2009 @ 04:14 PM

    • Milestone cleared.
    • Assigned user set to “josh”
  • josh

    josh February 12th, 2009 @ 08:10 PM

    • State changed from “new” to “open”

    Could you please attach a unit test as well.

    Actually, I think we could omit that entire method. Rack should be normalizing the header keys so it shouldn't really matter in this case.

    Can you try to reproduce the error and see if removing the method altogether will fix it too?

  • Repository

    Repository February 16th, 2009 @ 08:18 PM

    • State changed from “open” to “resolved”

    (from [0096eb1555a3e61e89ff90eddefdc28739adc618]) Removed dead convert_expires! in Response [#1952 state:resolved]

    Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

  • Joe F.

    Joe F. February 17th, 2009 @ 02:26 PM

    Thanks for taking care of this! Sorry I never updated my patch, this was my first submission and I wasn't sure where to put the test. Where exactly did you put the test for this? I'd like to take a look at it so I have a better idea next time.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Referenced by

Pages