This project is archived and is in readonly mode.
Ruby 1.9 compat: plugin/install git://... always fails in Ruby 1.9
I found that
% script/plugin install git://...
always fails bacause FileUtils.mkdir_p does not return a string value in Ruby 1.9.
Attatched a patch to fix this problem.
-
plugin_mkdir_p.diff
946 Bytes
-
Akira Matsuda- Tag changed from edge, git, plugin, ruby1.9, script to 2.3.2, edge, git, patch, plugin, ruby1.9, script
Updated tags since I believe Rails 2.3 stable still needs this patch.
-
alan+1
-
Niels Ganser- Tag changed from 2.3.2, edge, git, patch, plugin, ruby1.9, script to 2.3.2, edge, git, patch, plugin, ruby1.9, ruby19, script
+1
Patch applies cleanly on my system and works as advertised.
ordimini% ./script/about
About your application's environment
Ruby version 1.9.1 (x86_64-linux)
RubyGems version 1.3.1
Rack version 1.0
Rails version 2.3.2
Active Record version 2.3.2
Action Pack version 2.3.2
Active Resource version 2.3.2
Action Mailer version 2.3.2
Active Support version 2.3.2 -
Nick Quaranto+1 to this, definitely seeing it happen here.
% rails1.9 -v Rails 2.3.3 % rails1.9 plugintest % cd plugintest % ruby1.9 script/plugin install git://github.com/thoughtbot/hoptoad_notifier.git Plugin not found: ["git://github.com/thoughtbot/hoptoad_notifier.git"] -
Pratik- Milestone changed from 2.x to 2.3.4
-
Taylor lukI can confirm the same problem with Ruby 1.9 + Rails2.3
-
Peter Wagenet
Looks like this got missed in the rush to 2.3.4 as it's still an issue. And yes, the patch works for me as well.
-
-
Jeremy Kemper
- State changed from new to committed
2-3-stable: c5e3309bb4e63fafb363da8f7eb2364530f9f96f
master: 3ce16b4c5fd3007d6b43364253506462e680b227
-
OwenWhen is 2.3.6 to be released? This is still a problem...