This project is archived and is in readonly mode.

[PATCH] 2.3.2 text_area_tag calling stringify_keys two times

#2587

Hello,

The text_area_tag is calling stringify_keys 2 times unnecessary. See:


      def text_area_tag(name, content = nil, options = {})
        options.stringify_keys!

        if size = options.delete("size")
          options["cols"], options["rows"] = size.split("x") if size.respond_to?(:split)
        end

        content_tag :textarea, content, { "name" => name, "id" => name }.update(options.stringify_keys)
      end

The first time, the method is called to self instance and second time is called again (unnecessary).

Thank you

Reported by Gabriel Sobrinho · April 30th, 2009 @ 07:59 PM

Activity

CancelProfileIsBroken
- Tag changed from 2.3.2, action_view to 2.3.2, action_view, bugmash
August 6th, 2009 @ 02:20 PM
Rizwan Reza
+1 verified. I removed the second method call to stringify_keys in the second last line and verified that all the tests still pass.

August 7th, 2009 @ 08:13 PM
Steve St. Martin
+1 verified. I removed second call to stringify_keys on line 265, I've attached a patch all tests still pass
- patch.diff 1.04 KB
August 8th, 2009 @ 01:08 AM
Steve St. Martin
- Title changed from 2.3.2 text_area_tag calling stringify_keys two times to [PATCH] 2.3.2 text_area_tag calling stringify_keys two times
August 8th, 2009 @ 02:52 AM
Elad Meidar
+1 verified, patch added to test app and a mini app, both pass completely as well as Rails tests.

August 8th, 2009 @ 03:42 AM
Repository

(from [a8645593a4446a89b2e699e153adca968340581a]) remove duplicate call to stringify_keys [#2587 [PATCH] 2.3.2 text_area_tag calling stringify_keys two times status:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/a8645593a4446a89b2e699e153adca...

August 8th, 2009 @ 02:01 PM
CancelProfileIsBroken
- State changed from new to resolved
August 8th, 2009 @ 08:38 PM
Greg Sterndale
+1 verified. patch applied, tests pass

August 8th, 2009 @ 10:45 PM
Edd Morgan
Applied and tests pass OK on 2-3-stable. +1 here

August 8th, 2009 @ 11:02 PM
CancelProfileIsBroken
- Tag changed from 2.3.2, action_view, bugmash to 2.3.2, action_view
- Milestone cleared.
August 8th, 2009 @ 11:07 PM