This project is archived and is in readonly mode.

#2587 ✓resolved
Gabriel Sobrinho

[PATCH] 2.3.2 text_area_tag calling stringify_keys two times

Reported by Gabriel Sobrinho | April 30th, 2009 @ 07:59 PM

Hello,

The text_area_tag is calling stringify_keys 2 times unnecessary. See:


      def text_area_tag(name, content = nil, options = {})
        options.stringify_keys!

        if size = options.delete("size")
          options["cols"], options["rows"] = size.split("x") if size.respond_to?(:split)
        end

        content_tag :textarea, content, { "name" => name, "id" => name }.update(options.stringify_keys)
      end

The first time, the method is called to self instance and second time is called again (unnecessary).

Thank you

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Referenced by

Pages