This project is archived and is in readonly mode.
Add :margin option to XmlSerializer
When building custom XML with XmlSerializer (for ActiveRecord) its nice to be able to use the margin option of XMLBuilder rather than reformatting the string output or instantiating a builder.
builder = options[:builder] ||= ::Builder::XmlMarkup.new(:indent
=> options[:indent], :margin =>
options[:margin])
-
xml_serialize_margin.diff
1.85 KB
-
CancelProfileIsBroken- Tag changed from serializer, xml to bugmash, serializer, xml
-
ThePhred
I was able to modify the patch to get it to cleanly apply. Tests still pass.
I've attached a patch. -
Rizwan Rezaverified
+1 The patch applies cleanly to 2-3-stable and all the tests pass.
This doesn't work for master though.
-
Elad Meidar+1 Verified +1 patch applies for 2-3-stable with all tests.
i think that on master you can simply specify :margin in a to_xml block.
-
Derander
+1 verified, patch applies to 2-3-stable, all tests pass.
I agree with Elad, this shouldn't be necessary in master.
-
josh- State changed from new to invalid
I don't think yet another option to the to_xml hash is going solve the worlds problems. We need a more robust way to override to_xml and do your own customizations.
-
Jeremy Kemper- Tag changed from bugmash, serializer, xml to serializer, xml
- Milestone cleared.