#2733 [PATCH] Memoize cookies so they can be retrieved in the same response / request cycle - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2733 ✓resolved

[PATCH] Memoize cookies so they can be retrieved in the same response / request cycle

Reported by Olly | May 28th, 2009 @ 01:40 PM | in 2.3.4

If you set a cookie in a controller action and then try and access the new value in later in the action or in the view, the old value for the cookie is retrieved because the CookieJar is re-initialized with each call to ActionController::Base#cookies.

# Contrived example
# Before patch:
def show
  cookies[:logged_in] = true
  cookies[:logged_in] # => nil
end

# After patch:
def show
  cookies[:logged_in] = true
  cookies[:logged_in] # => true
end

Related thread on Core mailing list.

0001-Memoize-cookies-so-that-updates-to-cookies-are-avail.patch 1.6 KB

Comments and changes to this ticket

josh May 28th, 2009 @ 03:10 PM
- Milestone cleared.
- State changed from “new” to “open”
- Assigned user set to “josh”
Repository May 28th, 2009 @ 03:35 PM
- State changed from “open” to “resolved”
(from [0349278f3da9f7f532330cf295eed35ede3bae66]) Memoize cookies so that updates to cookies are available in the current request. [#2733 state:resolved]

Signed-off-by: Joshua Peek josh@joshpeek.com
http://github.com/rails/rails/commit/0349278f3da9f7f532330cf295eed3...
Repository July 21st, 2009 @ 10:47 PM
(from [143c55d325388aa2384de8f137cfb61c09912208]) Memoize cookies so that updates to cookies are available in the current request. [#2733 state:resolved]

Signed-off-by: Joshua Peek josh@joshpeek.com

Conflicts:
```
actionpack/test/controller/cookie_test.rb
```
http://github.com/rails/rails/commit/143c55d325388aa2384de8f137cfb6...
You flagged this item as spam.
Bryan Helmkamp August 10th, 2009 @ 11:49 PM
This change introduced a regression which is captured here: https://rails.lighthouseapp.com/projects/8994/tickets/3032-regressi...
Jeremy Kemper August 10th, 2009 @ 11:50 PM
- State changed from “resolved” to “open”
- Milestone set to “2.3.4”
Bryan ran into a regression with this.
You flagged this item as spam.
John Pignata August 25th, 2009 @ 04:57 AM
Bryan -- I'm not sure that this actually did introduce a regression. Your test seems to work when I call cookies.clear against the controller which is how the other tests interact with it
```
  def test_cookies_are_clearable_from_test
    get :authenticate
    @controller.send(:cookies).clear
    response = get :count
    assert_equal "0", response.body
  end
```
josh August 31st, 2009 @ 07:45 PM
- State changed from “open” to “resolved”
Reresolving.

We should update the functional test cookie accessor to behave more like the integration one.