This project is archived and is in readonly mode.
SessionHash#update and SessionHash#delete are missing a call to load!
Reported by Alexey Borzenkov | August 15th, 2009 @ 02:39 PM
In file actionpack/lib/action_dispatch/middleware/session/abstract_store.rb update and delete are missing a call to load! before calling super. If the data was not loaded before these functions are called, then super will operate on an empty hash, and results will be discarded when it is loaded later. The attached patch should fix the problem.
Comments and changes to this ticket
-
Alexey Borzenkov August 15th, 2009 @ 02:42 PM
- Tag changed from “:delete, :update, load!, missing, session” to “:delete, :update, load!, missing, patch, session”
Added patch tag
-
Alexey Borzenkov August 28th, 2009 @ 08:50 PM
- Assigned user set to “josh”
-
Repository August 31st, 2009 @ 07:39 PM
- State changed from “new” to “resolved”
(from [6f40139b53b8e9ac805a15bb7c070d7bf9f6ce66]) SessionHash#update and SessionHash#delete are missing a call to load! [#3056 state:resolved] http://github.com/rails/rails/commit/6f40139b53b8e9ac805a15bb7c070d...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Alexey Borzenkov
josh
Attachments
Referenced by
-
2530
SessionHash#delete not implemented
Duplicate of #3056
-
3056
SessionHash#update and SessionHash#delete are missing a call to load!
(from [6f40139b53b8e9ac805a15bb7c070d7bf9f6ce66])
Session...
-
2530
SessionHash#delete not implemented
This bug is superseded by #3056, which is now resolved