This project is archived and is in readonly mode.
Empty Set-Cookie header
Reported by Urban Hafner | January 29th, 2010 @ 02:26 PM | in 2.3.6
The current (as of 2.3.5)
ActionController::Response#convert_cookies! method
generates an empty Set-Cookie header if there aren't
any cookies. This gets caught by (at least) thin and webrick. Both
remove the empty Set-Cookie header line. However
unicorn doesn't and I think it's Rails responsibility to not
generate a header like this. Changing the
convert_cookies! method to something like this fixes
the problem:
def convert_cookies!
cs = Array(headers['Set-Cookie']).compact
headers['Set-Cookie'] = cs unless cs.empty?
end
Comments and changes to this ticket
-
Jeremy Kemper January 29th, 2010 @ 11:51 PM
- Milestone set to “2.3.6”
- State changed from “new” to “open”
- Assigned user set to “josh”
-
Repository February 2nd, 2010 @ 02:54 PM
- State changed from “open” to “resolved”
(from [0c0da1a6e080c7450b54150aa9bc999130e59352]) Fix empty Set-Cookie headers [#3811 state:resolved] http://github.com/rails/rails/commit/0c0da1a6e080c7450b54150aa9bc99...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Eike Herzbach
Jeremy Kemper
josh
Tags
Referenced by
-
3811
Empty Set-Cookie header
(from [0c0da1a6e080c7450b54150aa9bc999130e59352])
Fix emp...
-
2449
ActionController::Flash::InstanceMethods::flash triggers the lazy sessions
https://rails.lighthouseapp.com/projects/8994/tickets/38...
-
2449
ActionController::Flash::InstanceMethods::flash triggers the lazy sessions
It is related. How did you fix it? The fix for #3811 isn'...