Activity (RSS)

While running some tests which require modifying some fields in a DB table, I ran across a problem that made me lose quite some time. The error I got when run...

It seems like an obvious typo, but why are the tests passing without the fix?

In the test that checks if named_scope is accessible through a has_many :through association was broken.

There is a typo in it and the appropriate fixtures ar...

In the TimeZone class in ActiveSupport, there is a convenience method us_zones that dynamically creates a list of all time zones for the U.S.

As is easy to se...

(from [7708650f73ddb4db300ea2059c60c1d907a4384e]) Added conditional support to caches_action [José Valim] [#166 state:resolved]

http://github.com/rails/rails/...

Hurray! Tests are passing. We'll take that patch ;)

Can you please use mocking instead of sleep(0.01) ?

Thanks.

I have no better idea at the moment. Put abstractly, there needs to be a way to parameterize where a failed validation add its message.

Errr, I really don't like this either. How could we refactor validations so you could write a plugin easier?

Pratik, unfortunately this can't be done in a plugin without copying almost all of the validations -- which would be subject to break with changes in Rails.

T...

I'm very tempted to say "Plugin material".

Hi Pratik,

If the suggestion-type language is too superfluous for a Rails error message, may I suggest two alternatives that avoids the Windows-esque type err...

I think this should be in a plugin like http://groups.google.com/group/r...

Thanks!

Sorry about that. I didn't know I wasn't supposed to fork Rails unless it's some big change. I deleted my fork.

I'm not sure if this is required or not, but here is my commit on my fork of Rails on GitHub:

http://github.com/arya/rails/com...

ActiveRecord raises an exception when the expected class for an association differs from the class of object trying to be assigned.

Example:

@post.comments <...

My schema definition is:

create_table :cached_method_items do |t|

t.string :key

t.text :value

t.datetime :expires_at

t.timestamps

end

The model is hidde...

What does your model look like (specifically, the serialize call)?

What does your model table schema look like (specifically the value field)?

Why don't use ...

In certain cases it is preferable to call check_box multiple times with the same method but with a different checked_value. This makes it work assuming that ob...

One against edge would be nicer. But if you can't, then 2.0.x is fine too and I'll try to port it to edge.

Thanks.

I can write a failing test against 2.0.2, but to get one against edge is going to take me a while. Would 2.0.2 be good enough?

-Chris

Could you please add a failing test case ?

Thanks.

This should be fixed in development version of haml. Please use haml from http://github.com/nex3/haml/tree... and may be convince Nathan to release a new gem :...

That sounds reasonable, I'll have a look at it when I find the time.

No worries.

Just FYI there are three issues remaining:

• HasManyThroughAssociation#build_sti_condition, as Jonathan mentioned above.
• ActiveRecord::Base#type_...

That's great. Thanks Rick.

About having extra table, sorry about that. I did that to avoid breaking other things, my bad.

getting this for 5.0.51a when running the AR test suite:

test_nil_defaults_for_not_null_columns(DefaultTest)
    [./test/cases/defaults_test.rb:17:in `test_n...

do you have any config.gem lines in your environment.rb file?

(from [bca8751e40a5594c4de2ca58e089b8d98e44632b]) Add ActiveRecord option to store the full class name on STI's type column, allowing one to have STI subclasse...

Also, I'm going to remove the choice since it shouldn't break for anyone. Anyone using STI without namespaced models will be unaffected, and this bug is basic...

I really want this in 2.1. Though, the default should be off to keep the existing behavior, and on for Rails 3.0 and forward.

I also agree that the new table...

http://dev.rubyonrails.org/ticke...

I'm not sure why this occurred only when Rails was loaded in its production environment and not the development environment, but this seems to be due to the do...

With ActiveRecord 2.0.2, define the following classes.

class A < ActiveRecord::Base

class B < A

class C < B

Implement all three with single table inheritan...

Works fine for me.

Looks good, but its making my AR integration tests fail for some reason. Maybe it has something todo w/ the tests you changed. Anyone else having this problem?...

http://github.com/rails/rails/co...

The HAML plugin breaks on Rails 2.1 RC 1 because it attempts to register itself as a template handler, and results in error:

/Library/Ruby/Gems/1.8/gems/haml-...

Sure :)

Attached patch includes a failing test case as well as the fix and is done with git-format-patch.

Could you please send me ('lifo') a PM at github and I'll add you to commit list of docrails http://github.com/lifo/docrails - so that you can commit the patch...