Activity (RSS)

(from [3a0d8adcf25e27f7976a1d0996be05f21ffc3805]) Fix tests broken by mocha absence [#186 state:resolved]

Two ActiveRecord tests depended on mocha but were no...

Two ActiveRecord tests fail when mocha is not installed. The attached patch adds a uses_mocha wrapper to restore the test suite to passing.

http://github.com/rails/rails/co...

I've attached a new patch addressing this issue along with a test for it.

This change seems to change the behavior of deleting a cookie. When a cookie is deleted it's value is set to an empty string. Previously that would have meant:...

This happens in the ERB template in the current edge as well as 2.0.2. This behavior is strange, and shouldn't happen...

First Invocation

<%=link_to('First L...

Yup the issue I reported has gone away. Thanks Rick!

Awesome I think that will work. Lemme report right back after trying this in production with edge + config.gem.

Hey, I had that fix already in my rails fork, but I hadn't merged it:

http://github.com/rails/rails/co...

It's merged now, let me know how it works.

(from [92e2e5990cc2aa4f699c286ac5d1f73e27ede548]) include bugfix to [e792d4ab70448f79142fdf492390682ff5ea6398] for rubygems 1.0.1. Gem::DependencyList#depende...

Made use escape_javascript() helper method instead of the regexp in your patch.

Thanks.

+1. Simple fix.

(from [3fee2378edd45188e41a7d14d4ca0a88280b541e]) Use 'public' schema path when connecting to 'postgres' database. [#170 state:resolved]

Signed-off-by: Pratik...

I've been testing these out on Lighthouse for the past week without problems. I think we're doing better now, but please shower us with patches/failing test c...

(from [0697d17d121fcf9f46b5dd2dd1034dffa19ebdf2]) Change the request forgery protection to go by Content-Type instead of request.format so that you can't bypas...

(from [c8451aeeea200043d8a3e6eae9c49def3a154ddb]) change ActionController::RequestForgeryProtection to use Mime::Type#verify_request? [#73]

http://github.com/...

Consider a route that is restricted to just HEAD requests. For example:

map.resource :session, :collection => {:status => :head}

This action can never be i...

shazzam

I thought it was pretty common practice to use UTC. But if this is what the people want, then so be it!

My thought is simply that including the offset gives you more meaningful data, and you can easily convert to UTC if you want it.

This is a good catch -- we should make the output of #to_json consistent across Time, DateTime, and TimeWithZone instances.

The outstanding question is, is th...

form_for('post[]', @post) do |f|
  f.fields_for('comment[]', @comment) do |c|
    c.text_field(:name)
  end
end

I expect:

<input name="post[123][comment]...

Hi Adam,

I agree with all suggestions ( only a. and c. are relevant now ) made by Jon.

You need to add tests to rails' existing test suite, which would fail ...

And also, it'd be nicer if you create the .diff using git-format-patch, so that you get the credit when patch is committed :)

Do you have a failing test case ?

Thanks.

Attached a new copy of the patch. This one should work.

The uploaded patch seems garbled. Could you please upload a new patch ?

Thanks.

Could you please upload a single patch ? I'm a little confused with 3 uploded patches. Also, it's good idea to use git-format-patch to create the diff file, so...

Committed to docrails - http://github.com/lifo/docrails/...

Also added you to the project, just in case you have anything more in the future :)

Thanks.