#3022 [PATCH] ActiveSupport tests fail when run from a directory with a space in its location - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3022 ✓committed

[PATCH] ActiveSupport tests fail when run from a directory with a space in its location

Reported by Kieran P | August 9th, 2009 @ 08:44 AM

When ActiveSupport test suite is run from a directory path that contains a space (e.g. /Users/rails/Rails Edge/) then the test fail. When the space is removed, they work again.

http://pastie.org/577274

Comments and changes to this ticket

You flagged this item as spam.
John Pignata August 9th, 2009 @ 02:15 PM
Adding a patch to wrap the shell call with quotes
- fix_tests_when_rails_in_a_directory_with_a_space.diff 871 Bytes
You flagged this item as spam.
John Pignata August 9th, 2009 @ 03:18 PM
- Tag changed from “1.8.6, 3.0, activesupport, active_support, bugmash, errors, rails, tests” to “1.8.6, 3.0, activesupport, active_support, bugmash, patch”
- Title changed from “ActiveSupport tests fail when run from a directory with a space in its location” to “[PATCH] ActiveSupport tests fail when run from a directory with a space in its location”
You flagged this item as spam.
Simon Jefford August 9th, 2009 @ 05:02 PM
+1 issue exists without patch, patch fixes issue and applies cleanly
You flagged this item as spam.
Rajesh August 9th, 2009 @ 05:15 PM
verified on master branch
You flagged this item as spam.
Elad Meidar August 9th, 2009 @ 05:27 PM
+1 verified and applies on master, fails on 2-3-stable.
You flagged this item as spam.
Simon Jefford August 9th, 2009 @ 05:29 PM
verified - forgot the magic word in my earlier comment
You flagged this item as spam.
Dan Croak August 9th, 2009 @ 05:44 PM
+1 verified issue exists in 2-3-stable.

I've attached a patch that applies cleanly in 2-3-stable.
- 3022-fix-AS-tests-when-path-has-space-2-3-stable.patch 997 Bytes
You flagged this item as spam.
Josh Nichols August 10th, 2009 @ 05:01 AM
+1, for freedome of having rails wherever you want, and still being able to run the tests.

Verified applies on both 2-3 and master.
Jeremy Kemper August 10th, 2009 @ 06:37 AM
- Tag changed from “1.8.6, 3.0, activesupport, active_support, bugmash, patch” to “1.8.6, 3.0, activesupport, active_support, patch”
- State changed from “new” to “committed”
2-3-stable doesn't have isolation tests so I'm not sure what the above patch is for.
Repository August 10th, 2009 @ 06:37 AM
(from [793a9f122f66c28cfb58cd885a9a8cda35c4a0dd]) Fixing isolation test

[#3022 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/793a9f122f66c28cfb58cd885a9a8c...