Activity (RSS)

The previously mentioned commit referenced/closed the wrong ticket. Please reopen.

(from [96d9691e71319f4c166315a36b96c2c3c54ed493]) FormHelper#label_tag accepts :for option [encoded] [#38 state:resolved]

http://github.com/rails/rails/co...

Rails source can be cloned but it's rake task "package" is broken. Tested on Mac OS X 10.5.2.

rake package --trace
(in /Users/zbiru/Documents/GITS/merb-scrip...

How where those connections created? I think SQLite actually just compares the string, doesn't it? So if you created those rows with something else than Rails,...

Hmm, that's weird, it definitely does not work for me. I'm on OS X 10.5, with SQLite 3.5.2 from MacPorts.

$ sqlite3 development.sqlite3

SQLite version 3.5.2...

Using 't' and 'f' seems to work fine on sqlite3:

sqlite> SELECT * FROM "posts" WHERE (live = 't');

2|ab|2008-04-30 20:58:22|2008-04-30 20:58:22|t

sqlite> SE...

Crap, totally screwed up my SQL. Here is the correct SQL for the Ruby code I posted.

User.find(:all, :conditions => ['active = ?', true])

Current, incorrec...

The current SQLiteAdapter does not format true/false conditions correctly for queries. It is using the default quoted_true and quoted_false methods.

The ruby...

(from [c83f75812ef89aea1b8d138aebec25de8057f156]) Fixed labels that have a bracketed name and an index [#68 state:resolved]

Signed-off-by: Joshua Peek

http:...

(from [c83f75812ef89aea1b8d138aebec25de8057f156]) Fixed labels that have a bracketed name and an index [#68 state:resolved]

Signed-off-by: Joshua Peek

http:...

expect

<label for="author_post_1_title">

get

<label for="author_post_title">

The following does not create the correct label:

fields_for("author[post]", @post, :index => 1) do |f|
  f.label(:title)
  f.text_field(:title)
end

expec...

rebased patch against current

http://github.com/rails/rails/co...

http://github.com/rails/rails/co... is passing.

Could try to pull some of the changes down, if they're nicely branched in git I guess...

Could try to pull some of the changes down, if they're nicely branched in git I guess...

Closed by http://github.com/rails/rails/co...

+1

update_with_lock isn't quoting the table name, so if you have a Reference model with optimistic locking, things will fail when you save a record. Simple fix, ...

The recent schema.rb work broke the :build_postgresql_databases tasks, and were missing an 'IF EXISTS' clause that prevented the schema being loaded correctly ...

Looking good, but missing docs and tests. Please change status to open when fixed.

(from [a3da293b3363a56c28773088cbf932115eb3a2b0]) Fixed render :partial => @collection.named_scope (nkallen) [#61 state:resolved]

http://github.com/rails/rail...

Fixed:

http://github.com/nkallen/rails/...

Some tests in AP are red right now I'm pretty sure it's not my fault.

In edge rails, sending in request attributes with the following:

&email[to_new_contacts][][contact_attributes][first_name]=first

&email[to_new_contacts][][co...

Hi Simon,

The config.gems was originally started as a yaml file approach, but then that was decided against.

If you want a robust approach which uses a yaml ...

(from [1282ddaadcfc361f55fa0d5661d9d0036bd571c1]) Fixed tabs to spaces [#47 state:resolved]

http://github.com/rails/rails/co...

Change ticket status to open when fixed.

Change ticket status to open when fixed.

Ah, okay. Yeah, I could definitely see this make sense before the include? fix. I don't think we need it now, though.

David, this was an extract of something we wrote before include? got that optimization, so yes, it's equivalent functionality now. If you care about Law of De...

(from [869d731cca89759f6dd7c141776b5d7358b59b9d]) Fixed response logging to use length instead of the entire thing (seangeo) [#27 state:resolved]

http://githu...

(from [10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7]) Fixed that change_column should be able to use :null => true on a field that formerly had false [Nate Wiger] ...

Closed by http://github.com/rails/rails/co...