Activity (RSS)

I don't think I understand the difference between alex.friends.include?(josh) and alex.has_friend?(josh)? (now that the include? call has been optimized to not...

Instead of invoking find_by_id and instantiating a new model, could you instead rely on the optimized include? association method?

http://dev.rubyonrails.org/...

Good stuff, but I don't think it belongs in core. There are not enough compelling reasons to specify your dependencies in a yml file for the general "most peop...

Darn...

typos in there, meant to say Post.find(:first) rather than Post.find(:all) everywhere.

Eager loading a has_one with :order is not consistent.

Post.has_many :comments

Post.has_one :latest_comment, :class_name => 'Comment', :order => 'created_at ...

I added this ticket over at prototype.lighthouse. I do not have privileges to close this one.

This should be on the prototype light house (http://prototype.lighthouseapp.com/)

Given that prototype is modeled after Ruby, it seems like the in place '!' versions of these functions are missing. Since Array.prototype.reverse already takes...

If you have an observer, then doing rake db:create in some circumstances (one is described below) causes rail to die with 'unknown database'.

Obviously a circ...

Moved patch to its own branch:

http://github.com/tomafro/rails/...

When I tried to use render :partial => @collection.active (active being a named_scope) I got the following error:

Couldn't find template file for active_recor...

==============

from the patch

==============

Subject: [PATCH] adding :through option to "named_scope"

named_scope is a welcome addition to rails core,

and...

While creating specs for a method to generate valid GraphML, I needed to use attributes with periods ('.') in their names (i.e. ''). However, as it stands, as...

In fact there's no provision for it doing anything but plugins in vendor/rails (eg if you have plugins in a non standard directory)

As a test, I converted one of my plugins to a gem and gave it a rails/init.rb file.

The plugin itself loads fine (very sweet feature BTW), however the extra t...

Attaching new patch - previous one was missing a test case.

@logger seems to have gone missing too

We should make sure to deprecate @action_name and the rest of the ivars that were removed in http://github.com/rails/rails/co... for Rails 2.0.x. I stumbled ov...

The new "named_scope" functionality is great.

But it feels like it should have the option of specifying a :through scope name,

through which the scope will b...

I've just had the irritating experience of:

$rake db:create
rake aborted!
Unknown database 'foo'

... which resulted from a plugin's ActiveRecord model ref...

If I call render :template => "template" (which lives in app/views/template.html.erb) in my controller, I get the error, that the template doesn't exist. But i...

A recent change to the MySql adapter adds smallint and bigint support based on the specified :limit. Since the default integer limit is specified as 11, intege...

I did wonder. I will let the core team decide based on what they know and would prefer. Both patches are there.

Using returning reduces performance. Since create is a common operation, my suggestion might not be worth it.

Cheers, applied in http://github.com/rails/rails/co...

Sorry, this is a duplicate of #2. I didn't found the search option before. Admit it, the tiny magnifier on the right is hard to spot if everything else of the ...

The file at http://dev.rubyonrails.org/archi... has a length of 0 bytes. Seems to be the case for more than a week!

We are actually moving in the opposite direction, Errors will soon become more hash like. So #invalid? will be replaced by errors.any?.

Attaching a patch instead - gonna delete my branch.

Removes the options argument from trunk and add a deprecation warning to stable branch