This project is archived and is in readonly mode.
improve mailer generator and add tests
Reported by Mislav | April 18th, 2008 @ 10:55 PM
This is what mailer generator used to generate:
class Notifier < ActionMailer::Base
def reset_password()
@subject = "..."
@from = "..."
# ...
end
end
You see that it used instance variables, while the documentation clearly advocates usage of methods. This patch changes output to:
def reset_password()
subject "..."
from "..."
# ...
end
It also cleans up the generator test suite, removing quite a lot duplication, and adds mailer test for the first time.
Comments and changes to this ticket
-
Mislav April 18th, 2008 @ 10:55 PM
- no changes were found...
-
Mislav April 18th, 2008 @ 11:11 PM
Added third commit. This is how the generated mailer now looks like:
script/generate mailer notifier reset_passwordIn @app/models/notifier.rb@:
class Notifier < ActionMailer::Base # change to your domain name default_url_options[:host] = 'example.com' def reset_password(sent_at = Time.now) subject 'Notifier#reset_password' recipients '' from '' sent_on sent_at body :greeting => 'Hi,' end end -
josh April 18th, 2008 @ 11:17 PM
- State changed from “new” to “resolved”
- Assigned user set to “josh”
-
-
josh April 18th, 2008 @ 11:22 PM
Question, how did you diff those patches? It included your name and email at the top which is really nice.
Can you doc the process under Ticket Guidelines Authorship.
-
Mislav April 18th, 2008 @ 11:53 PM
git format-patch HEAD~3I can't edit Ticket Guidelines, only core team can.
-
Cody Fauser April 21st, 2008 @ 01:09 PM
Great changes overall. However, I did notice one small potential issue. I don't think the default_url_options[:host] call should be placed in the mailer. This seems to promote setting the host in each mailer, but the host is likely to be the same in most cases. Also, default_url_options is a mattr_accessor so the settings in each mailer will overwrite each other, which is likely to be confusing for the developer.
It seems more useful to use something like the following in the application's configuration:
config.action_mailer.default_url_options = { :host => 'myhost.com' } -
Mislav April 21st, 2008 @ 01:15 PM
Well, I generally agree. We only have to update docs for ActionMailer and we can remove `default_url_options` from generator.
-
Cody Fauser April 21st, 2008 @ 03:16 PM
Please take a look at #32. I created a patch which updates the documentation and removes the default_url_options call from the generator.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Cody Fauser
Mislav
Attachments
Tags
Referenced by
-
32
Remove default_url_options from mailer generator. Improve mailer docs
See #20 for more details.
-
99
SQLite connection failing
ActionView::TemplateError (Could not find table 'users') ...
-
99
SQLite connection failing
ActionView::TemplateError (Could not find table 'users') ...
-
684
NameError after creating scaffolding for object "Dive"
Showing dives/index.html.erb where line #20 raised:
-
684
NameError after creating scaffolding for object "Dive"
Extracted source (around line #20):