This project is archived and is in readonly mode.

#20 ✓resolved
Mislav

improve mailer generator and add tests

Reported by Mislav | April 18th, 2008 @ 10:55 PM

This is what mailer generator used to generate:

class Notifier < ActionMailer::Base
  def reset_password()
    @subject = "..."
    @from    = "..."
    # ...
  end
end

You see that it used instance variables, while the documentation clearly advocates usage of methods. This patch changes output to:

  def reset_password()
    subject "..."
    from    "..."
    # ...
  end

It also cleans up the generator test suite, removing quite a lot duplication, and adds mailer test for the first time.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Referenced by

Pages