This project is archived and is in readonly mode.
[PATCH] Ability to set SSL options on ActiveResource connections
Reported by rnicholson | March 29th, 2009 @ 05:56 AM
ActiveResource currently has no means to set SSL connection options. Ability to do so is useful when, for example, the server requires X509 certificate peer authentication.
Attached patch adds the ability to specify SSL options on ActiveResource connections.
Comments and changes to this ticket
-
-
CancelProfileIsBroken August 6th, 2009 @ 02:48 PM
- Tag changed from “activeresource, patch, ssl” to “activeresource, bugmash, patch, ssl”
-
Dan Pickett August 8th, 2009 @ 11:45 PM
+1 for the feature
could not get this to apply cleanly to 2-3-stable or master
I'm not sure this belongs in 2.x, though. Maybe edge? I wonder too if we could put all this configuration in a module - lots of great and usable configuration, though
-
Elad Meidar August 9th, 2009 @ 03:08 AM
+1 for feature, definitely missing -1 on patch, "Patch does not have a valid e-mail address."
-
rnicholson August 9th, 2009 @ 04:26 AM
Updated patch.
Agree that this isn't 2.x. I'm not sure how it got that tag. If I did it, sorry about that.
-
rnicholson August 9th, 2009 @ 07:21 PM
Updated patch again to merge cleanly with changes from a0caad5255ed120192755fce10960a38b53c056d
-
rnicholson August 9th, 2009 @ 07:24 PM
- no changes were found...
-
David Trasbo August 9th, 2009 @ 07:41 PM
-1
The idea is good but the patch does not apply to edge Rails.
-
rnicholson August 9th, 2009 @ 08:59 PM
can you explain? git apply ares_ssl_options.diff works fine for me in master.
Am I doing something wrong in making the patch?
-
Elad Meidar August 9th, 2009 @ 09:23 PM
+1 verified
patch applies on master with warnings:
Applying: Add ability to set SSL options on ARes connections. /Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:27: trailing whitespace. # /Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:38: trailing whitespace. # /Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:54: trailing whitespace. # * <tt>:verify_depth</tt> - The maximum depth for the certificate chain verification. /Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:55: trailing whitespace. # * <tt>:cert_store</tt> - OpenSSL::X509::Store to verify peer certificate. /Users/eladmeidar/projects/bugmash/vendor/rails/.git/rebase-apply/patch:61: trailing whitespace. warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. -
Repository August 9th, 2009 @ 09:24 PM
- State changed from “new” to “committed”
(from [de0b073f3e7db069e3a572f142ce7a5241b102c2]) Add ability to set SSL options on ARes connections.
[#2370 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/de0b073f3e7db069e3a572f142ce7a... -
Repository August 9th, 2009 @ 09:24 PM
(from [3e0951632c52018eefb86d9e0bfe77383f9622fb]) Add ability to set SSL options on ARes connections.
[#2370 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/3e0951632c52018eefb86d9e0bfe77... -
CancelProfileIsBroken August 9th, 2009 @ 10:05 PM
- Tag changed from “activeresource, bugmash, patch, ssl” to “activeresource, patch, ssl”
- Milestone cleared.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
CancelProfileIsBroken
Attachments
Tags
Referenced by
-
2370
[PATCH] Ability to set SSL options on ActiveResource connections
[#2370 state:committed]
-
2370
[PATCH] Ability to set SSL options on ActiveResource connections
[#2370 state:committed]
-
781
ActiveResource should allow SSL verification
#2370