Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their options

+1 This would definitely be helpful for plugin development

This patch does not apply cleanly anymore. I will try to extract the parts that should apply and see if the filtering is needed.

I have adapted the patch so that it applies on master, some small cleanups here and there.

The filtering is currently needed, because the tests in i18n_generate_message_validation_test.rb have a very precise expectations of how methods are being called. Here is an example:

  def test_errors_add_on_empty_generates_message
    @person.errors.expects(:generate_message).with(:title, :empty, {})
    @person.errors.add_on_empty :title
  end

I would like to make that more flexible so the code can be more flexible. This code already gives a lot more flexibility.

I have ran all tests for activemodel and activerecord. I have added Sven Fuchs to the authors.

I forgot the patch...

The goal of the commit was to make the validations more flexible. The whitelist approach was an intermediate solution to satisfy the strict tests. My plan was to see how I could make the tests more flexible to make the code more flexible and have the whitelist removed. I thought that would be easier when the whitelist was in one spot.

Anyhow, I think I know how to approach this problem better now. I'll work on a new patch.

Jeroen, open the ticket when you attach the fix.

+1 Patch applies and tests run.

I have, however, taken the liberty of removing whitespace errors - patch preserves authorship.

Sorry, but patch does not apply anymore. Would anyone mind to rebase? Also, there is a TODO: in the tests, would be nice if we could apply the tests without the TODO.