PATCH: primary_key option for belongs_to

I dug into the unit tests and believe I've added a correct unit test to test this functionality.

$ rake test_sqlite3 TEST=test/cases/associations/belongs_to_associations_test.rb
(in /Users/philip/Work/Careers.org/web/vendor/rails/activerecord)
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby -Ilib:test:test/connections/native_sqlite3 "/Library/Ruby/Gems/1.8/gems/rake-0.8.1/lib/rake/rake_test_loader.rb" "test/cases/associations/belongs_to_associations_test.rb"
Using native SQLite3
Loaded suite /Library/Ruby/Gems/1.8/gems/rake-0.8.1/lib/rake/rake_test_loader
Started
....................................
Finished in 0.472048 seconds.

36 tests, 123 assertions, 0 failures, 0 errors

Original patch with unit tests is attached.

Same patch with tests in format correct git/rails format for submission.

This patch doesn't cover creation (State.cities.build(...)) correctly.

Updated patch to fix association build/create.

A few comments:

*

owner_id = @reflection.options.has_key?(:primary_key) ? @owner.send(@reflection.options[:primary_key]) : @owner.id

might be a bit neater as

owner_id = @owner.send(@reflection.options[:primary_key] || :id)

• You'll need to handle eager & preloading
• the find_by bit in find_target looks a bit grungy

Just wanted to add some additional motivation for this patch. I'm using uuids in a multi-machine, multi-database configuration with ActiveResource. Since objects are moved between databases on each machine, they can't use the autoincrementing 'id' column, hence uuids. Changing the database primary key to be a uuid has a negative impact on Innodb performance so this patch is the right solution.

Is there a workaround or patch available for has_and_belongs_to_many?

This is a must have feature for us. We are using the finder_sql for the has_many relationship but need this to get the belongs_to to work.

We currently need to regularly import data from a legacy system and combine them with additional records from the system. Using a separate key would solve the issue.

Complete the patch and the feature will go into Rails. It's that easy :)

I've applied this patch by hand and it doesn't work in 2.2.

The find_target and set_belongs_to_association_for methods aren't even called.

I've overridden the modules and put the file at rails initializers folder.

The original patch only works for things like that: Occupation.find(:first).aliases.create(:name => 'alias name')

But doesn't works for: al = Alias.new(:name => 'alias name') al.occupation = Occupation.find(:first)

Follow attached all my overrides in ActiveRecord that worked. I've put together previous patch and changes at: ActiveRecord::Associations::ClassMethods.belongs_to ActiveRecord::Associations::BelongsToAssociation.replace

I know, I should at least make a diff, but it is 5am here in Brazil, I'm tired.

Thanks

I could use this feature right now. Will definitely +1 a good patch.

Good feature; still incomplete.

(from [1c11437a32a973fa9b521c32caa7256f9772acd7]) Add primary_key option to belongs_to association

[#765 PATCH: primary_key option for belongs_to state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/1c11437a32a973fa9b521c32caa725...

Joey, there's another ticket open for this, but I can't find it for the life of me.

This seems as useful a place to put the following patch as well. Looks like association.rb wassn't accounting for :primary_key option in association_join.

This seems to fix the issue for me.

I'd include a test but I'm leaving to head to my wedding in about 2 hours and need to finish up some work. :)

+1

It looks like the patch has a test there contrary to the comment.

Ahhh... good point.. I'll see if I can bang out a test tonight and get this thing finished.

I have been a bit busy (insert jokes here) but just came back to see my patch was still missing tests. Here you go. Also, I think the existing test_belongs_to_with_primary_key may not be testing what it's supposed to be testing -- but to be safe I just created a new test.

Not to be a nuisance, as I'm sure that everyone (like me) is far too busy working on Rails 3 related stuff at the moment, but was wondering if anyone had taken a look at the updated patch with tests.

Jeremy, yes, it was against 2-3-stable. I combined both mine and Joey's against the current 2-3-stable. I'm assuming that's what you meant since a rebase against master would be for Rails 3. :) Let me know if this does the trick.

Thanks! Yes, for Rails 3. All new development happens on master first, then we may backport to 2-3-stable. Adding a feature to 2-3-stable that isn't on master would be broken.

Oh. My assumption (perhaps incorrectly) was that this wasn't broken in Rails 3 with the Arel-based overhaul. Maybe that's wrong. Let me go back and rebase against master and see how horribly broken the patch is. :)

Here we go. I was wrong, these were broken in Rails 3 too. Here's a working patch.

(from [715b34fdff1e1e93204e57737d69f8d365e17504]) use supplied primary key when eager-loading belongs_to associations rather than default primary key

[#765 PATCH: primary_key option for belongs_to ]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/715b34fdff1e1e93204e57737d69f8...

Automatic cleanup of spam.