Activity (RSS)

Added another patch which uses returning. I will let the core team decide what they prefer.

Thanks for the suggestion Matt.

Sure that would be nice. I was not sure how often 'returning' was being used in rails code. I thought of it more as for external use.

From greping the rails e...

Perhaps a tangent, but why not replace

object = new(attributes)

yield(object) if block_given?

object.save

object

with

returning new(attributes) do |objec...

Right. Still trying to get the hang of this git business. [monki] is good enough for this time, I'll know better next time.

I've applied this now.

If you want to have your name and email show up in the logs, you'll need to use git format-patch --stdout. But thanks for the fix in t...

(from [f3fd44f76b64d6c30967a31b91709d27bce41f72]) Add default options to file_store to make it align with the other cache stores. [monki]

[#40 state:resolve...

For an example, see the test fixture in the patch.

Commit on github

+1

+1

The initializer uses vendor_rails? to decide whether or not to install gem stubs, but it's not guaranteed to be there during upgrades. I've patched the initial...

ugh, closing again.

yeah, that was it.

Man that was an awesome error ;)

(from [44d214235271cb6d2af1c327d592a3010e1ced3e]) Ensure table names are quoted by the association preloading code.

[#45 state:resolved]

Signed-off-by: Micha...

Ah, the attachment was there the whole time, I just didn't see it over on the right-hand side. Sorry.

Hrm, I seem to be unable to add an attachment... I selected my patch file in the Upload Attachment field, but it did not appear with the ticket... Any idea w...

When using the label method on a form builder, it seems useful to be able to manually set a for attribute. Currently the to_label_tag method will either overr...

When using a model that is associated (via has_many) with other models, it is often convenient to be able to ask the containing model whether it contains (or "...

I think i've fixed the files with no new lines at the end. This should make everything hunky-dory

I've had a bit of a fiddle and I can reproduce this if i edit jobs.yml (added in this patch) so that the last line reads

magician:
  id:

instead of

magici...

Wow, that obviously didn't happen when I ran the tests. I tried again applying the patch to a clean checkout of rails and it still looks ok (I cleared out the ...

Applying this causes stacks of errors:

1418 tests, 4864 assertions, 2 failures, 70 errors

Most of them are:

test_eager_with_invalid_association_reference(Ea...

Make AP not care about whether keys are strings or integers

The scaffold templates view_edit.html.erb and view_new.html.erb use tabs to indent the recently added label lines. These tabs are copied into any code generate...

Updating rails re-broke this for me today, anything else I can do to help get this in? Ie, poke? I think with the patch attached now it should be good to go,...

Attached test showing with_scope injecting false attributes when :joins key is used in scope.

Ah good point - sorry didn't notice the tagging. Checking it out now.

Attached change to ActiveRecord::Base that gives precedence to last-specified select and provides table-name scoping to selects where joins are involved in the...

Using with_scope with a :joins option does not narrow returned fields to those on the primary model resulting in join table attributes being added to the prima...

If that test passes, then I'd say it's fixed in trunk but not in 2-0-stable, since the test is doing just what my expectation is.

Anyone know if there was a f...

Just put some tests together to see if this needed fixing. Looks like it doesn't. Please could someone check my tests?

Kee

As per the FIXMEs in the source, it wasn't quoting table names. Naughty.

Hi,

This is a follow up to my previous patch on Trac ticket #11181.

I refactored the code a bit and included more thorough tests. Plus I fixed a stupid bug o...

+1

This example fails:

1. @article has_one :feed

render :partial => @article.feed

The expected behavior is that @article.feed is assigned to the local variable ...

Yep, deleting it restored functionality for me, too, tho I forgot to come back and mention that at some point.

Looks like this isn't necessary anymore. I removed the lines:

if ActiveRecord::Base.connection.supports_migrations?

File.open("db/#{RAILS_ENV}_structure.sql...

Do I need to get this +1'd by other people?

"rake db:create" should honor all PostgreSQL database creation options allowed in the adapter's create_database method, and specified in database.yml.

http://...

Lighthouse is out to get me! or something.

Sorry about that, re-uploading now.

We're looking into the zip file, it appears to be cron jobs stomping on one another or something.

As for this, perhaps we could extract this all into a class ...

(from [30ad1827a66b8578cabc8f14a67c69b0ab17cf92]) preventing generated documentation from being picked up by git. [#37 state:resolved]

Signed-off-by: Michael ...

Updated patch with conforming more to rails conventions with blocks.