This project is archived and is in readonly mode.
3.x
Progress
% Complete
Tickets Left
Aaron Patterson
4 open tickets
Closed tickets 38
-
2297:through Associations don't respect default_scoperesolved -
6050code cleanupcommitted -
5995adopt coding conventioncommitted -
5996remove the rescue block. perform optimizationcommitted -
5997fix warning during testresolved -
5972Do not perform another sql if association is already loaded for empty hashcommitted -
5910tiny cleanupinvalid -
5596perf: for .last method delay Array#join operationcommitted -
5743No need to check for nilcommitted -
5744Fix wrong testresolved -
5734No need of extra checkcommitted -
5725performance improvementcommitted -
5595perf: no need to flatten args if args is blankinvalid -
5640Arel is not MIT licensedresolved -
5594minor performance improvementcommitted -
5584make apply_modules run fastercommitted -
5379[PATCH] Removing "symbol to proc" usage from Active Recordcommitted -
4881ActiveSupport::TimeWithZone#period raises an exception when using a nil timezoneresolved
Sunday, March 13 2011
-
- Milestone set to 3.x
MarcRic,
Do you feel as though documenting the --no-migration option in help would help to clarify this issue, and maybe adding a caveat to the --skip help text...
Saturday, March 12 2011
-
-
-
- State changed from new to open
- Milestone set to 3.x
- Assigned user set to Dan Pickett
- Importance changed from to Low
If no one objects, I don't think this is a bug, and I'd like to close this out.
I think the require statement in my comment above is what gem authors should be ...
Friday, March 11 2011
-
Prem Sichanugrist (sikachu) commented at 2:09 AMThank you for updating my patch and push them for me. ;)
Jeez, seems like I keep overlooking something.
Thursday, March 10 2011
-
Repository commented at 11:34 PM(from [68802d0fbe9d20ef8c5f6626d4b3279bd3a42d3e]) Filter sensitive query string parameters in the log [#6244 state:committed]
This provides more safety to appli...
-
- State changed from open to committed
(from [434e451221cd3d19e4575e26799ee53954347a03]) Filter sensitive query string parameters in the log [#6244 state:committed]
This provides more safety to appli...
-
Xavier Noria commented at 11:18 PMLooks good to me. I have been working a bit on the patches:
-
Semicolon as a separator was untested
-
The edge case /foo?secret (no equal sign) was not handled ...
-
-
-
- State changed from incomplete to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
Wednesday, March 09 2011
-
John Mileham commented at 8:14 PM
Hi,
Just wanted to note here that I submitted a patch for #5060 that would change the semantics of #count to apply the :limit and :offset first. If that approac...
-
- Assigned user changed from Prem Sichanugrist (sikachu) to Xavier Noria
I've update the patch to fixes those issues above, and add those cases as the test.
I've included patch for
masterand3-0-stable. The only difference is the CH...
Monday, March 07 2011
-
Repository commented at 4:51 PM
(from [9cee693213e0205cb5992728bb516215e34cb79f]) Merge branch 'master' of github.com:rails/rails
- 'master' of github.com:rails/rails: (44 commits) Fixed indent...
-
Repository commented at 4:51 PM
(from [9cee693213e0205cb5992728bb516215e34cb79f]) Merge branch 'master' of github.com:rails/rails
- 'master' of github.com:rails/rails: (44 commits) Fixed indent...
Sunday, March 06 2011
-
Repository commented at 7:26 AM
(from [e00867bc437b6a681491ef59e13423051e6d98f0]) Raise ArgumentError if route name is invalid [#6517 state:resolved] https://github.com/rails/rails/commit/e00...
-
- State changed from open to resolved
(from [2437c78f40d5e89aa3dc1c960bbe12fe0427b627]) Raise ArgumentError if route name is invalid [#6517 state:resolved] https://github.com/rails/rails/commit/243...
-
Andrew White commented at 6:16 AM
But if you just strip the name your routes.rb file is left with an invalid argument - something I'd prefer to know.
-
lakshmanan commented at 6:03 AM
@Diego +1
I think, at least we must :strip the name before considering. Deigo's patch does exactly that.
-
Andrew White commented at 5:17 AM
Thanks, Diego but I think it's better to raise an exception - the name may be invalid for other reasons such as a leading number, space in the middle, etc.
-
Diego Carrion commented at 5:10 AMI attached a patch in case the expected behavior is not to break.
-
- State changed from open to resolved
(from [0509bf35f1987c1e0b9c3dd1389778f8426180f7]) Allow model to be inherited from Hash [#6487 state:resolved]
Signed-off-by: Andrew White andyw@pixeltrix.co.uk
... -
-
Diego Carrion commented at 3:53 AM
Hi, attached is the failing test. The patch from wildchild make it pass.
Saturday, March 05 2011
-
- State changed from new to open
- Milestone set to 3.x
- Assigned user set to Andrew White
- Importance changed from to Low
It needs a require added for extract_options! from ActiveSupport and some tests, then I can push it.
Friday, March 04 2011
-
- State changed from open to committed
(from [0db915efd1240f493c50b7b9f5d1ea5f1e3eec10]) Add an option to FormBuilder to omit hidden field with id
[#4551 state:committed]
Signed-off-by: Santiago Past...
-
-
- State changed from new to open
- Milestone set to 3.x
- Assigned user changed from Santiago Pastorino to Andrew White
What's happening is the :as option is used as the named route helper method name. The fix is to raise an ArgumentError when the route is being defined if the :a...
-
- State changed from open to wontfix
Sorry Sam, but this doesn't worth the risk of breaking something in stable
Thursday, March 03 2011
-
Lenary commented at 7:44 PMD'awww. time to change track i think. That said, i do think that these kinds of things should get into stable, but i understand your time constraints
-
-
Christopher Meiklejohn commented at 4:03 AMI confirmed that this patch applies cleanly to the 3-0-stable; fails on master.
Wednesday, March 02 2011
-
- State changed from new to open
- Milestone set to 3.x
- Assigned user set to Santiago Pastorino
- Importance changed from to Low
Doesn't apply cleanly. Please rebase it.
-
- Milestone changed from 2.3.10 to 3.x
- Assigned user changed from Frederick Cheung to Aaron Patterson
Tuesday, March 01 2011
-
-
- Tag changed from :include, :joins, activecord, named_scope to activecord, include, joins, named_scope
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
-
-
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
Sunday, February 27 2011
-
- State changed from open to resolved
(from [86ad8a6c877636b4df7966233dff7fea377b0790]) Make sure the Thor generator LoadError does not output --dev twice [#6431 state:resolved]
Signed-off-by: Santi...
-
- State changed from new to open
- Assigned user changed from Jeff Kreeftmeijer to Santiago Pastorino
After discussing with José, it turned out testing this would be difficult and result in a brittle test:
(07:44:10 PM) José Valim: there is no need to test it (...
Saturday, February 26 2011
-
-
rails commented at 12:05 AM
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
-
-
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
-
-
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
-
-
- Tag changed from 2.2.2, habtm, named_scope to 222, habtm, named_scope
- State changed from incomplete to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
-
-
- Tag changed from 2.3.2, activerecord, nested, rollback, testcase to 232, activerecord, nested, rollback, testcase
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
No messages in this milestone.