This project is archived and is in readonly mode.
[PATCH] Prefer tap over returning in ActionMailer
Reported by Matías Flores | September 27th, 2009 @ 08:29 PM
ActiveSupport's returning function has been replaced by object#tap whenever was possible.
I've attached a patch to start using tap in the only place in ActionMailer where returning was still being used.
This patch is valid for both master and 2-3-stable.
Comments and changes to this ticket
-
Elad Meidar September 27th, 2009 @ 08:49 PM
There's also lib/active_support/core_ext/enumerable.rb#78 and lib/active_support/core_ext/range/blockless_step.rb#15
-
-
Matías Flores September 27th, 2009 @ 09:00 PM
Yes, I wasn't sure if we'd need one patch for each lib or a single one that updates actionmailer, activesupport, etc. Should I change the patch? Add more patches to this ticket and rename it to remove the reference to ActionMailer? Or just focus on ActionMailer and have other tickets for the other components?
-
Gaius Centus Novus September 27th, 2009 @ 09:12 PM
+1 And I think one patch file per major area should do, not one patch per file.
-
-
Matías Flores September 27th, 2009 @ 10:15 PM
Ok. I have created a new ticket with a separate patch for ActiveSupport at https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...
-
-
-
Gaius Centus Novus September 27th, 2009 @ 11:49 PM
- Tag changed from “actionmailer, bugmash, patch” to “2-3-stable, actionmailer, bugmash, patch”
See also #3284 for ActiveRecord
-
-
Gaius Centus Novus September 27th, 2009 @ 11:59 PM
- Title changed from “Prefer tap over returning in ActionMailer” to “[PATCH] Prefer tap over returning in ActionMailer”
-
CancelProfileIsBroken September 28th, 2009 @ 01:31 AM
- Tag changed from “2-3-stable, actionmailer, bugmash, patch” to “2-3-stable, actionmailer, bugmash-review, patch”
-
Repository September 28th, 2009 @ 03:29 AM
- State changed from “new” to “committed”
(from [173ee14c3d95238cfb828400862a24a14aec600f]) Prefer tap to returning
Signed-off-by: Michael Koziarski michael@koziarski.com
[#3280 state:committed] http://github.com/rails/rails/commit/173ee14c3d95238cfb828400862a24... -
Rizwan Reza May 15th, 2010 @ 06:42 PM
- Tag changed from “2-3-stable, actionmailer, bugmash-review, patch” to “2-3-stable, actionmailer, patch”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Matías Flores
Attachments
Tags
Referenced by
-
3283
[PATCH] Prefer tap to returning in ActionPack
Along the lines of #3280 and #3281, but for ActionPack. P...
-
3284
[PATCH] Prefer tap to returning in ActiveRecord
Along the lines of #3280, #3281, and #3283, but
for Actio...
-
3285
[PATCH] Prefer tap to returning in Railties
Like #3280, #3281, #3283,
#3284, but for Railties. Tested...
-
3280
[PATCH] Prefer tap over returning in ActionMailer
Signed-off-by: Michael Koziarski
michael@koziarski.com
[#...