This project is archived and is in readonly mode.
[PATCH] Prefer tap over returning in ActionMailer
ActiveSupport's returning function has been replaced by object#tap whenever was possible.
I've attached a patch to start using tap in the only place in ActionMailer where returning was still being used.
This patch is valid for both master and 2-3-stable.
-
Elad MeidarThere's also lib/active_support/core_ext/enumerable.rb#78 and lib/active_support/core_ext/range/blockless_step.rb#15
-
-
Matías FloresYes, I wasn't sure if we'd need one patch for each lib or a single one that updates actionmailer, activesupport, etc. Should I change the patch? Add more patches to this ticket and rename it to remove the reference to ActionMailer? Or just focus on ActionMailer and have other tickets for the other components?
-
Gaius Centus Novus
+1 And I think one patch file per major area should do, not one patch per file.
-
Elad Meidar
+1 agreed, 1 patch per major lib should cover it.
-
Matías Flores
Ok. I have created a new ticket with a separate patch for ActiveSupport at https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...
-
Gaius Centus Novus
+1 verified against 2.3 stable
-
Gaius Centus Novus
See also #3283 [PATCH] Prefer tap to returning in ActionPack (same for ActionPack)
-
Gaius Centus Novus
- Tag changed from actionmailer, bugmash, patch to 2-3-stable, actionmailer, bugmash, patch
See also #3284 [PATCH] Prefer tap to returning in ActiveRecord for ActiveRecord
-
Gaius Centus Novus
See also #3285 [PATCH] Prefer tap to returning in Railties for Railties
-
Gaius Centus Novus
- Title changed from Prefer tap over returning in ActionMailer to [PATCH] Prefer tap over returning in ActionMailer
-
CancelProfileIsBroken
- Tag changed from 2-3-stable, actionmailer, bugmash, patch to 2-3-stable, actionmailer, bugmash-review, patch
-
Repository
- State changed from new to committed
(from [173ee14c3d95238cfb828400862a24a14aec600f]) Prefer tap to returning
Signed-off-by: Michael Koziarski michael@koziarski.com
[#3280 [PATCH] Prefer tap over returning in ActionMailer state:committed] http://github.com/rails/rails/commit/173ee14c3d95238cfb828400862a24... -
Rizwan Reza- Tag changed from 2-3-stable, actionmailer, bugmash-review, patch to 2-3-stable, actionmailer, patch