cache_sweeper yields blank output

I'm seeing this too. Instead of running any code in the method, I get the following plus a blank screen:

Completed 200 OK in 717ms

I'm running:

ruby 1.9.2dev (2010-04-02 trunk 27189) [x86_64-darwin10]
Rails 3.0.0.beta2

Looks like ActionController::Caching::Sweeper doesn't return true as a default when callbacks aren't run (!controller.perform_caching).

Including a patch.

Now I'm pushing up to staging I see that the before filter will need to return true in all cases. This is because the sweeper filter aspect is really implementation detail, and sweepers shouldn't prevent actions running like regular filters can.

I've updated the patch.

I am not able to simulate this problem in rails edge. Could you try to simulate this problem with rails edge and see if it is still an issue.

Reproduced on edge Ref: 6d7f2790cdb6cb232850, May 6, 2010

class MainController < ApplicationController
cache_sweeper :app_sweeper

def index end end

class AppSweeper < ActionController::Caching::Sweeper
end

Verified Si's patch 'return_true_for_non_caching_sweeper_filter.diff' fixes the issue.

NO clue if this breaks anything else, but my page is loading.

...and I take that back. I added an after_save to the sweeper and we're back to the original issue -> blank output

Attached is a patch with test. I was not really sure how to go about testing this one. So any feedback on testing strategy is welcome.

Hi Kevmoo, I updated that patch but the fix is the same in Neeraj's diff. Can you try that?

Applied, but still need better tests.