Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar's latest activity

Sunday, August 09 2009
2481 Console/log output for malformed XML requests is not very helpful was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 9:12 PM

    +1 Verified... /!\ so annoying /!\

    Patch applies and all tests pass on 2-3-stable (it's more of an output formatting thing... needs tests?)

    Attached a patch for...

2630 Adding a validates_with method was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 8:57 PM

    +1 verified and applied on 2-3-stable and master. +1 on idea too, i have been doing those dependent validations for a while too, trying to find a better way.. g...

2316 [PATCH] 410 Gone as ResourceGone for ActiveResource was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 8:52 PM

    +1 Verified, applies and tests pass on 2-3-stable.

    Attached patch and tests for master (my name appears on the commit, i didn't know how to credit the original ...

2698 Add :margin option to XmlSerializer was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:38 PM

    +1 Verified +1 patch applies for 2-3-stable with all tests.

    i think that on master you can simply specify :margin in a to_xml block.

2723 to_xml generates invalid xml with namespaced ActiveRecord was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:25 PM

    +1 verified, +1 patch applies and tests pass on 2-3-stable with the same warning as Abhishek Parolkar described.

    using #class will just return the Column instan...

2306 AssociationCollection's destroy method is not compatible with old version was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 6:58 PM

    +1 Verified, +1 on the catch, i am usually using delete since i almost never REALLY destroy data in my applications.

    +1 patch applies to 2-3-stable and master, ...

2558 Support for :joins in ActiveRecord::Base#update_all was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 6:51 PM

    +1 Verified, -1 Patch i agree with Matt, seems like it's a better approach to leave #update_all limited and not encourage AR workarounds that will probably lead...

2707 dbconsole support password passing through /dev/fd/ was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 6:49 PM

    i didn't quiet understand how to reproduce this ticket, pointers?

1956 [PATCH] json validations errors for ActiveResource was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 6:07 PM

    +1 Verified, +1 on 2-3-stable patch => applies and all tests pass, +1 on master patch => applies and all tests pass

2353 helper caching issue was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 5:56 PM

    -1 was unable to reproduce. I agree with nick, use of #to_s with a custom format is probably the consist way to approach this.