Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar's latest activity

Saturday, August 08 2009
2745 db:sessions:clear to respect legacy table names was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:51 PM

    Sorry, patch apply to 2-3-stable, not master.

  • Elad Meidar
    Elad Meidar commented at 4:14 PM

    +1 for the first patch, +1 for relevancy.

    You can change the name by specifying:

     ActiveRecord::SessionStore::Session.table_name = 'new_session_table_name'
    

    in...

2997 [PATCH] db:drop:all throws error when database does not exist was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:28 PM

    +1 except patch is not applying. "Patch does not have a valid e-mail address."

2944 Titleize doesn't take all-uppercase words into account was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:21 PM

    -1 leave #titlieze alone too, it is an edge cases that require this much attention anyways.

  • Elad Meidar
    Elad Meidar commented at 4:26 AM

    +1 verified Patch applies, and all tests run.
    Previous error was due to my mistake, sorry.

  • Elad Meidar
    Elad Meidar commented at 4:01 AM

    Patch does not apply. i wasn't able to determine the reason so the patch was not fixed.

2587 [PATCH] 2.3.2 text_area_tag calling stringify_keys two times was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 3:42 AM

    +1 verified, patch added to test app and a mini app, both pass completely as well as Rails tests.