Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Activity (RSS)

Wednesday, May 28 2008
252 Default 500 error message shouldn't imply notification was updated
  • Wincent Colaiuta
    Wincent Colaiuta commented at 1:00 PM

    I also don't use the default, but I think that accuracy is more important than creating an illusion of professionalism. It's about integrity: if Rails tells li...

  • Adam C
    Adam C commented at 11:11 AM

    Hi Pratik,

    It doesn't really affect me as I don't use the default anyway - as I'm sure lots of people do. But, although it sounds professional, it isn't accur...

  • Pratik
    • State changed from new to invalid
    by Pratik at 11:04 AM

    The current one sounds more "professional" and it's very easy to change if you wish to for your application.

    Feel free to disucss it over rails core mailing l...

267 form_for for singular resource will products plural invokes was created
  • soliiid
    soliiid created the ticket at 8:35 AM

    for example:

    in routes.rb

       map.resource :profile, :controller => 'profile'
    

    in view:

       <% form_for(@profile) do |f| %>
          ...
          <%= f.submit "S...
259 Load plugin rake tasks before root/lib/tasks was updated
  • Ryan Bates
    Ryan Bates commented at 6:10 AM

    +1 it makes sense that project specific tasks would override all others.

256 Model objects are falsely marked as not-new after transaction rollback was updated
  • Carl Porth
    Carl Porth commented at 6:05 AM

    I'm attaching an update to TransactionTest#test_callback_rollback_in_create to expose this bug. Perhaps it will be of use to someone who knows the transaction...

69 UrlEncodedPairParser creates wrong params hash with nested attributes in arrays was updated
  • Carl Porth
    Carl Porth commented at 3:56 AM

    In the following arguments, you are treating email[to_new_contacts] like an array with []

    &email[to_new_contacts][][contact_attributes][first_name]=first

    &em...

75 Routing - Receptors with a dot in the name was updated
  • Carl Porth
    Carl Porth commented at 3:29 AM

    Try passing a Regexp in your route definition like this:

    map.request_upload '/indir/:random_id/:filename', :controller => 'uploads', :action => 'request_file'...
266 Added rake install task was created
  • Jaroslaw Zabiello
    Jaroslaw Zabiello created the ticket at 12:07 AM

    Added 'install' task which generate and install all gems.

Tuesday, May 27 2008
264 The diff command in script/generate doesn't escape paths. was created
  • Carl Porth
    Carl Porth created the ticket at 10:32 PM

    When doing a script/generate and a file exists, doing a diff (to view the differences between the generated file and the one that already exists) doesn't escap...

103 Lighthouse Rake Tools was updated
263 calling named scope in class method was created
  • Ryan Bates
    Ryan Bates created the ticket at 4:11 PM

    When a named scope is called inside a class method, it loses the other scopes in the chain. For example:

    class Topic < ActiveRecord::Base
      named_scope :appr...
262 empty? on named_scope should use count was created
  • Ryan Bates
    Ryan Bates created the ticket at 3:35 PM

    Currently, calling empty? on named_scope loads all results. Instead I think it should behave more like an association proxy which uses a count query if the res...

261 ArgumentError using fixtures named test* was updated
  • Menno
    • Title changed from ArgumentError using fixtures named test... to ArgumentError using fixtures named test*
    by Menno at 3:18 PM
  • Menno
    Menno created the ticket at 3:15 PM

    After moving from Rails 1.2 to 2.0.2 using fixtures whose name starts with 'test' fails. Running 'rake' when having fixture test_whatevers.yml results in an

    1...

260 ActiveRecord: nested "include" hints fail if record classes are in modules was created
  • Rich Bradley
    Rich Bradley created the ticket at 12:17 PM

    ActiveRecord 2.0.2 can't load records whose classes are in modules when using nested "include"s.

    e.g.

    @edition = Edition.find_by_id(edition_id, {:include => ...

259 Load plugin rake tasks before root/lib/tasks was created
  • Ryan Kinderman
    Ryan Kinderman created the ticket at 4:27 AM

    I would like to be able to have the ability to access/modify rake tasks provided by a plugin from within my application, in tasks defined in #{RAILS_ROOT}/lib/...

258 Eager loading optimisation misses if order specified was updated
  • Jeremy Kemper
    • State changed from new to incomplete
    by Jeremy Kemper at 3:35 AM

    On what database? This works for me. Please attach a failing test case.

  • Zyclops
    Zyclops created the ticket at 3:02 AM

    When no conditions are passed into find, 2 individual queries are run. One to fetch from the table people and the other from addresses. When you provide some c...

Monday, May 26 2008
257 add branch option for 'script plugin/install' with git was created
  • David Chelimsky
    David Chelimsky created the ticket at 11:36 PM

    Being able to install plugins from git is a great start, but it would be even nicer if it supported a couple of options like --tag so i could do this:

    script/...
255 activerecord condition hashes should respect ruby range syntax was updated
  • Alex Arnell
    Alex Arnell commented at 7:00 PM

    updated ticket with proper git formatted patch

  • Alex Arnell
    Alex Arnell created the ticket at 4:59 PM

    Ruby has some explicit rules for Ranges,

    a = 1..10 => 1 through 10
    b = 1...10 => 1 through 9
    

    but activerecord doesn't follow those rules when uses conditio...

256 Model objects are falsely marked as not-new after transaction rollback was updated
  • Xavier Noria
    Xavier Noria commented at 6:17 PM

    Also timestamps are not rolled back, so the new record may have an initialized created_at. (Related to #93.)

  • pdietrich
    pdietrich created the ticket at 5:26 PM

    Consider the following code from a controller action:

    begin
      @auction.transaction do
        @auction.save!
        @lot.auction = @auction
        @lot.save!
        f...
Remove superfluous tests directive ht... was committed by Repository at 10:06 AM
Don't require AV::TestCases to have a... was committed by Repository at 10:06 AM
254 Q-encode: should use upper case was created
  • Kazuhiro Nishiyama
    Kazuhiro Nishiyama created the ticket at 5:54 AM

    In RFC 2047:

    (1) Any 8-bit value may be represented by a "=" followed by two

    hexadecimal digits. For example, if the character set in use

    were ISO-8859-1, ...

247 validates_associated - Detailed Validation error messages on associations was updated
  • Brian Takita
    Brian Takita commented at 2:30 AM

    I'm in favor of not having to validates_associated.

    I think that it would be useful to attach the name of the association that owns the invalid attribute beca...

250 Mysql Deadlock debugging was updated
  • Mike Perham
    Mike Perham commented at 2:22 AM

    One thing I forgot, the log_innodb_status method should be moved down to the private section.

  • Mike Perham
    Mike Perham commented at 2:11 AM

    Thanks for the pointer, Jeremy. Patch attached.

Fix tests for postgres 8.3.x Made te... was committed by Repository at 12:55 AM
Sunday, May 25 2008
250 Mysql Deadlock debugging was updated
  • Jeremy Kemper
    Jeremy Kemper commented at 11:25 PM

    Thanks Mike! Check out http://rails.lighthouseapp.com/p... for the skinny.

  • Mike Perham
    Mike Perham commented at 11:19 PM

    Jeremy, sorry I'm not terribly git-fluent. I've pushed a new commit with the error handling you requested to my fork but I don't know the exact patch command ...

  • Jeremy Kemper
    Jeremy Kemper commented at 9:38 PM

    This command is only available to mysql superusers so log_innodb_status should check for errors.

    Also, could you attach a patch created with git-format-patch?...

  • Mike Perham
    Mike Perham created the ticket at 5:01 PM

    Deadlocks and lock timeouts can be difficult to debug. This patch updates MysqlAdapter.execute to catch lock errors and print the results of SHOW INNODB STATU...

253 MySQL SSL settings do not always require the sslkey option was updated
  • Micah Wedemeyer
    Micah Wedemeyer commented at 11:00 PM

    I forgot to update the comments to add the sslca option. It's actually been in the code for a while, but never made it into the comments.

    Attaching a patch w...

  • Pratik
    • Title changed from [PATCH] MySQL SSL settings do not always require the sslkey option to MySQL SSL settings do not always require the sslkey option
    by Pratik at 10:38 PM
  • Micah Wedemeyer
    Micah Wedemeyer created the ticket at 9:58 PM

    Using the MySQL SSL settings in database.yml is conditional on there being an 'sslkey' option set. While this is sometimes the case, it's not always necessary...

247 validates_associated - Detailed Validation error messages on associations was updated
  • Anton Kuzmin
    Anton Kuzmin commented at 9:31 PM

    My damn brain and linux copy-paster :) Sorry

    • Anyway, I uncommented this line:
    • Anyway, I commented this line:
    • Now I don't even have to call validates_confir...
  • Anton Kuzmin
    Anton Kuzmin commented at 5:46 PM

    I used your patch. I was wondering, does user really need to know that his "Profile is invalid"?

    In fact, I see this message twice. I don't know exactly why. ...

251 Shouldn't script/generate scaffold create partials? was created
  • Dennis Theisen
    Dennis Theisen created the ticket at 7:04 PM

    Whenever I use the scaffold-generator for a model, I always find me editing the New, Edit, Show and Index views to render partials.

    Example:

    I have a Post ...

TimeZone#to_s shows offset as GMT ins... was committed by Repository at 5:56 PM
Merge docrails. Signed-off-by: Prati... was committed by Repository at 12:35 PM
230 Fire model callbacks before notifying observers was updated
  • josh
    • Milestone set to 2.1.1
    • State changed from new to open
    • Assigned user set to josh
    by josh at 12:29 AM
Saturday, May 24 2008
142 belongs_to association not updated when assigning to foreign key was updated
  • mattwestcott
    mattwestcott commented at 2:44 PM

    Following up on the possibility of overriding []= / write_attribute too - it looks like this isn't feasible. Various activerecord internals (such as the belong...

249 better coloration on error messages was updated
  • Adam S
    Adam S commented at 1:31 PM

    +1

    Errors can definitely be improved in Rails (see mod_rails errors for an example), these changes don't go a long way, but also don't hurt.

246 more verbose warning on boot failure was updated
  • Adam S
    Adam S commented at 1:15 PM

    +1

    Patch works and seems a reasonable change. I'm pretty sure I've had a similar issue where the LoadError that wasn't rubygems.

Create through associations can now w... was committed by Repository at 7:35 AM
248 Not able to use block-setting of attributes via association was updated
  • Repository
    • State changed from new to resolved
    by Repository at 7:35 AM

    (from [6cba97d2a449faf21aec9fe9d4434067e414226f]) Create through associations can now work with blocks.

    Signed-off-by: Michael Koziarski

    [#248 state:resolve...

Fix faulty tests introduced in 8d0b4f... was committed by Repository at 7:35 AM